Commit b53ea08
tls: remove SecureContext setFreeListLength
This function was introduced in 2684c90
as an internal helper function. The C++ implementation became a no-op in
a57e2f2 when building against OpenSSL
1.1.0 (instead of OpenSSL 1.0.2), and eventually became a no-op in all
supported OpenSSL versions in 970ce14.
Finally, eb20447 removed the only call
site of setFreeListLength (which was already a no-op at that point).
Refs: #1529
Refs: #10859
Refs: #19794
Refs: #38116
PR-URL: #44300
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 30cfe0a commit b53ea08
2 files changed
Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -283,7 +283,6 @@ Local<FunctionTemplate> SecureContext::GetConstructorTemplate( | |||
| 283 | 283 | env->SetProtoMethod(tmpl, "close", Close); | |
| 284 | 284 | env->SetProtoMethod(tmpl, "loadPKCS12", LoadPKCS12); | |
| 285 | 285 | env->SetProtoMethod(tmpl, "setTicketKeys", SetTicketKeys); | |
| 286 | - env->SetProtoMethod(tmpl, "setFreeListLength", SetFreeListLength); | ||
| 287 | 286 | env->SetProtoMethod(tmpl, "enableTicketKeyCallback", | |
| 288 | 287 | EnableTicketKeyCallback); | |
| 289 | 288 | ||
@@ -363,7 +362,6 @@ void SecureContext::RegisterExternalReferences( | |||
| 363 | 362 | registry->Register(Close); | |
| 364 | 363 | registry->Register(LoadPKCS12); | |
| 365 | 364 | registry->Register(SetTicketKeys); | |
| 366 | - registry->Register(SetFreeListLength); | ||
| 367 | 365 | registry->Register(EnableTicketKeyCallback); | |
| 368 | 366 | registry->Register(GetTicketKeys); | |
| 369 | 367 | registry->Register(GetCertificate<true>); | |
@@ -1119,9 +1117,6 @@ void SecureContext::SetTicketKeys(const FunctionCallbackInfo<Value>& args) { | |||
| 1119 | 1117 | #endif // !def(OPENSSL_NO_TLSEXT) && def(SSL_CTX_get_tlsext_ticket_keys) | |
| 1120 | 1118 | } | |
| 1121 | 1119 | ||
| 1122 | - void SecureContext::SetFreeListLength(const FunctionCallbackInfo<Value>& args) { | ||
| 1123 | - } | ||
| 1124 | - | ||
| 1125 | 1120 | // Currently, EnableTicketKeyCallback and TicketKeyCallback are only present for | |
| 1126 | 1121 | // the regression test in test/parallel/test-https-resume-after-renew.js. | |
| 1127 | 1122 | void SecureContext::EnableTicketKeyCallback( | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -100,8 +100,6 @@ class SecureContext final : public BaseObject { | |||
| 100 | 100 | #endif // !OPENSSL_NO_ENGINE | |
| 101 | 101 | static void GetTicketKeys(const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 102 | 102 | static void SetTicketKeys(const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 103 | - static void SetFreeListLength( | ||
| 104 | - const v8::FunctionCallbackInfo<v8::Value>& args); | ||
| 105 | 103 | static void EnableTicketKeyCallback( | |
| 106 | 104 | const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 107 | 105 | static void CtxGetter(const v8::FunctionCallbackInfo<v8::Value>& info); | |
0 commit comments