typings: correct param type of `SafePromisePrototypeFinally` · nodejs/node@b5bf08f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b5bf08f

Browse filesBrowse the repository at this point in the historyBrowse files

iwuliz

authored and

targos

committed

typings: correct param type of SafePromisePrototypeFinally

PR-URL: #54727 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

1 parent b6ed97c commit b5bf08f
Copy full SHA for b5bf08f

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/per_context
  • primordials.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/per_context/primordials.js‎

Copy file name to clipboardExpand all lines: lib/internal/per_context/primordials.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -461,7 +461,7 @@ const SafePromise = makeSafe(
461	461	* rejected). The resolved value cannot be modified from the callback.
462	462	* Prefer using async functions when possible.
463	463	* @param {Promise<any>} thisPromise
464		- * @param {() => void) | undefined | null} onFinally The callback to execute
	464	+ * @param {(() => void) | undefined | null} onFinally The callback to execute
465	465	* when the Promise is settled (fulfilled or rejected).
466	466	* @returns {Promise} A Promise for the completion of the callback.
467	467	*/

0 commit comments

Comments

0 (0)