Commit b5cdc27
build,win: improve logs when ClangCL is missing
PR-URL: #61438
Fixes: #61437
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent 0fb4642 commit b5cdc27
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -246,7 +246,7 @@ call :getnodeversion || exit /b 1 | |||
| 246 | 246 | set NODE_MAJOR_VERSION= | |
| 247 | 247 | for /F "tokens=1 delims=." %%i in ("%NODE_VERSION%") do set "NODE_MAJOR_VERSION=%%i" | |
| 248 | 248 | if %NODE_MAJOR_VERSION% GEQ 24 ( | |
| 249 | - echo Using ClangCL because the Node.js version being compiled is ^>= 24. | ||
| 249 | + echo ClangCL is required because the Node.js version being compiled is ^>= 24. | ||
| 250 | 250 | set clang_cl=1 | |
| 251 | 251 | ) | |
| 252 | 252 | ||
@@ -324,7 +324,7 @@ goto msbuild-found | |||
| 324 | 324 | ||
| 325 | 325 | :msbuild-not-found | |
| 326 | 326 | set "clang_echo=" | |
| 327 | - if defined clang_cl set "clang_echo= or Clang compiler/LLVM toolset" | ||
| 327 | + if defined clang_cl set "clang_echo= with Clang compiler/LLVM toolset" | ||
| 328 | 328 | echo Failed to find a suitable Visual Studio installation%clang_echo%. | |
| 329 | 329 | echo Try to run in a "Developer Command Prompt" or consult | |
| 330 | 330 | echo https://github.com/nodejs/node/blob/HEAD/BUILDING.md#windows | |
0 commit comments