Commit b5d0a03
test: fix error handling test-http-full-response
The way it is currently written, test-http-full-response will fail if
there is a problem with spawning that doesn't include `ab` or `api` in
`stderr`, but it will fail with a misleading mismatched-calls
`common.mustCall()` error.
Alter the error handling so that it rethrows the actual error, providing
better information.
PR-URL: #14252
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 32ba8ae commit b5d0a03
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -46,8 +46,7 @@ function runAb(opts, callback) { | |||
| 46 | 46 | common.printSkipMessage(`problem spawning \`ab\`.\n${stderr}`); | |
| 47 | 47 | process.reallyExit(0); | |
| 48 | 48 | } | |
| 49 | - process.exit(); | ||
| 50 | - return; | ||
| 49 | + throw err; | ||
| 51 | 50 | } | |
| 52 | 51 | ||
| 53 | 52 | let m = /Document Length:\s*(\d+) bytes/i.exec(stdout); | |
0 commit comments