src: remove unconditional NAPI_EXPERIMENTAL in node.h · nodejs/node@b606d46 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b606d46

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

aduh95

committed

src: remove unconditional NAPI_EXPERIMENTAL in node.h

PR-URL: #60345 Fixes: #60311 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>

1 parent 39dfcba commit b606d46
Copy full SHA for b606d46

6 files changed

+9-2Lines changed: 9 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• node.gyp
• src
  • js_native_api_v8.cc
  • node.h
  • node_api.cc
  • node_api_internals.h
  • node_binding.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -890,6 +890,9 @@
890	890	'NODE_ARCH="<(target_arch)"',
891	891	'NODE_PLATFORM="<(OS)"',
892	892	'NODE_WANT_INTERNALS=1',
	893	+ # Define NAPI_EXPERIMENTAL to enable Node-API experimental function symbols being exposed.
	894	+ 'NAPI_EXPERIMENTAL=1',
	895	+ 'NODE_API_EXPERIMENTAL_NO_WARNING=1',
893	896	# Warn when using deprecated V8 APIs.
894	897	'V8_DEPRECATION_WARNINGS=1',
895	898	'NODE_OPENSSL_SYSTEM_CERT_PATH="<(openssl_system_ca_path)"',

Collapse file

‎src/js_native_api_v8.cc‎

Copy file name to clipboardExpand all lines: src/js_native_api_v8.cc

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,9 @@
1	1	#include <algorithm>
2	2	#include <climits> // INT_MAX
3	3	#include <cmath>
	4	+ #ifndef NAPI_EXPERIMENTAL
4	5	#define NAPI_EXPERIMENTAL
	6	+ #endif
5	7	#include "env-inl.h"
6	8	#include "js_native_api.h"
7	9	#include "js_native_api_v8.h"

Collapse file

‎src/node.h‎

Copy file name to clipboardExpand all lines: src/node.h

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -76,7 +76,6 @@
76	76	#include "v8-platform.h" // NOLINT(build/include_order)
77	77	#include "node_version.h" // NODE_MODULE_VERSION
78	78
79		- #define NAPI_EXPERIMENTAL
80	79	#include "node_api.h"
81	80
82	81	#include <functional>

Collapse file

‎src/node_api.cc‎

Copy file name to clipboardExpand all lines: src/node_api.cc

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,9 @@
1	1	#include "async_context_frame.h"
2	2	#include "async_wrap-inl.h"
3	3	#include "env-inl.h"
	4	+ #ifndef NAPI_EXPERIMENTAL
4	5	#define NAPI_EXPERIMENTAL
	6	+ #endif
5	7	#include "js_native_api_v8.h"
6	8	#include "memory_tracker-inl.h"
7	9	#include "node_api.h"

Collapse file

‎src/node_api_internals.h‎

Copy file name to clipboardExpand all lines: src/node_api_internals.h

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -2,7 +2,9 @@
2	2	#define SRC_NODE_API_INTERNALS_H_
3	3
4	4	#include "v8.h"
	5	+ #ifndef NAPI_EXPERIMENTAL
5	6	#define NAPI_EXPERIMENTAL
	7	+ #endif
6	8	#include "env-inl.h"
7	9	#include "js_native_api_v8.h"
8	10	#include "node_api.h"

Collapse file

‎src/node_binding.h‎

Copy file name to clipboardExpand all lines: src/node_binding.h

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -8,7 +8,6 @@
8	8	#endif
9	9
10	10	#include "node.h"
11		- #define NAPI_EXPERIMENTAL
12	11	#include "node_api.h"
13	12	#include "quic/guard.h"
14	13	#include "uv.h"

0 commit comments

Comments

0 (0)