src: fix crash in GetErrorSource() for invalid using syntax · nodejs/node@b6219b6 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b6219b6

Browse filesBrowse the repository at this point in the historyBrowse files

semimikoh

authored and

aduh95

committed

src: fix crash in GetErrorSource() for invalid using syntax

Signed-off-by: semimikoh <ejffjeosms@gmail.com> PR-URL: #62770 Fixes: #62767 Refs: https://github.com/tc39/test262 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

1 parent 0e2adb3 commit b6219b6
Copy full SHA for b6219b6

1 file changed

+2-4Lines changed: 2 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_errors.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_errors.cc‎

Copy file name to clipboardExpand all lines: src/node_errors.cc

+2-4Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -150,8 +150,7 @@ static std::string GetErrorSource(Isolate* isolate,
150	150	: 0;
151	151	int start = message->GetStartColumn();
152	152	int end = message->GetEndColumn();
153		- if (start >= script_start) {
154		- CHECK_GE(end, start);
	153	+ if (start >= script_start && end >= script_start) {
155	154	start -= script_start;
156	155	end -= script_start;
157	156	}
@@ -161,8 +160,7 @@ static std::string GetErrorSource(Isolate* isolate,
161	160	CHECK_GT(buf.size(), 0);
162	161	*added_exception_line = true;
163	162
164		- if (start > end ||
165		- start < 0 ||
	163	+ if (start > end || start < 0 || end < 0 ||
166	164	static_cast<size_t>(end) > sourceline.size()) {
167	165	return buf;
168	166	}

0 commit comments

Comments

0 (0)