Commit b662c11
crypto: return the retval of HMAC_Update
Fixes coverity scan issue 55489.
PR-URL: #10891
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>1 parent 0c60540 commit b662c11
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3728,8 +3728,8 @@ void Hmac::HmacInit(const FunctionCallbackInfo<Value>& args) { | |||
| 3728 | 3728 | bool Hmac::HmacUpdate(const char* data, int len) { | |
| 3729 | 3729 | if (!initialised_) | |
| 3730 | 3730 | return false; | |
| 3731 | - HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len); | ||
| 3732 | - return true; | ||
| 3731 | + int r = HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len); | ||
| 3732 | + return r == 1; | ||
| 3733 | 3733 | } | |
| 3734 | 3734 | ||
| 3735 | 3735 | ||
0 commit comments