Commit b70eec8
tls_legacy: do not read on OpenSSL's stack
Do not attempt to read data from the socket whilst on OpenSSL's stack,
weird things may happen, and this is most likely going to result in some
kind of error.
PR-URL: #4624
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 3912b5c commit b70eec8
1 file changed
Lines changed: 8 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -614,13 +614,15 @@ function onclienthello(hello) { | |||
| 614 | 614 | ||
| 615 | 615 | if (err) return self.socket.destroy(err); | |
| 616 | 616 | ||
| 617 | - self.ssl.loadSession(session); | ||
| 618 | - self.ssl.endParser(); | ||
| 617 | + setImmediate(function() { | ||
| 618 | + self.ssl.loadSession(session); | ||
| 619 | + self.ssl.endParser(); | ||
| 619 | 620 | ||
| 620 | - // Cycle data | ||
| 621 | - self._resumingSession = false; | ||
| 622 | - self.cleartext.read(0); | ||
| 623 | - self.encrypted.read(0); | ||
| 621 | + // Cycle data | ||
| 622 | + self._resumingSession = false; | ||
| 623 | + self.cleartext.read(0); | ||
| 624 | + self.encrypted.read(0); | ||
| 625 | + }); | ||
| 624 | 626 | } | |
| 625 | 627 | ||
| 626 | 628 | if (hello.sessionId.length <= 0 || | |
0 commit comments