lib: use bracket notation instead of startsWith/endsWith for single char · nodejs/node@b71d5de · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b71d5de

Browse filesBrowse the repository at this point in the historyBrowse files

kimtaejin3

authored and

aduh95

committed

lib: use bracket notation instead of startsWith/endsWith for single char

Signed-off-by: Taejin Kim <rlaxowls1316@naver.com> PR-URL: #61500 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 parent 788976c commit b71d5de
Copy full SHA for b71d5de

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • socketaddress.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/socketaddress.js‎

Copy file name to clipboardExpand all lines: lib/internal/socketaddress.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -157,7 +157,7 @@ class SocketAddress {
157	157	hostname: address,
158	158	port,
159	159	} = URLParse(`http://${input}`);
160		- if (address.startsWith('[') && address.endsWith(']')) {
	160	+ if (address[0] === '[' && address[address.length - 1] === ']') {
161	161	return new SocketAddress({
162	162	address: address.slice(1, -1),
163	163	port: port | 0,

0 commit comments

Comments

0 (0)