crypto: fix subtle.getPublicKey error for secret type key inputs · nodejs/node@b738318 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b738318

Browse filesBrowse the repository at this point in the historyBrowse files

panva

authored and

targos

committed

crypto: fix subtle.getPublicKey error for secret type key inputs

PR-URL: #59558 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

1 parent 389a24b commit b738318
Copy full SHA for b738318

2 files changed

+8-2Lines changed: 8 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/crypto
  • webcrypto.js
• test/parallel
  • test-webcrypto-get-public-key.mjs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/crypto/webcrypto.js‎

Copy file name to clipboardExpand all lines: lib/internal/crypto/webcrypto.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1090,7 +1090,8 @@ async function getPublicKey(key, keyUsages) {
1090	1090	});
1091	1091
1092	1092	if (key[kKeyType] !== 'private')
1093		- throw lazyDOMException('key must be a private key', 'InvalidAccessError');
	1093	+ throw lazyDOMException('key must be a private key',
	1094	+ key[kKeyType] === 'secret' ? 'NotSupportedError' : 'InvalidAccessError');
1094	1095
1095	1096	const keyObject = createPublicKey(key[kKeyObject]);
1096	1097

Collapse file

‎test/parallel/test-webcrypto-get-public-key.mjs‎

Copy file name to clipboardExpand all lines: test/parallel/test-webcrypto-get-public-key.mjs

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -41,11 +41,16 @@ for await (const { privateKey } of [
41	41	name: 'SyntaxError',
42	42	message: /Unsupported key usage/
43	43	});
	44	+
	45	+ await assert.rejects(() => subtle.getPublicKey(publicKey, publicKey.usages), {
	46	+ name: 'InvalidAccessError',
	47	+ message: 'key must be a private key'
	48	+ });
44	49	}
45	50
46	51	const secretKey = await subtle.generateKey(
47	52	{ name: 'AES-CBC', length: 128 }, true, ['encrypt', 'decrypt']);
48	53	await assert.rejects(() => subtle.getPublicKey(secretKey, ['encrypt', 'decrypt']), {
49		- name: 'InvalidAccessError',
	54	+ name: 'NotSupportedError',
50	55	message: 'key must be a private key'
51	56	});

0 commit comments

Comments

0 (0)