doc: remove superfluous await from fsPromises.readdir example · nodejs/node@b819848 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b819848

Browse filesBrowse the repository at this point in the historyBrowse files

michaelrommel

authored and

targos

committed

doc: remove superfluous await from fsPromises.readdir example

The `await` operator in the example, iterating over the returned array of filenames is not necessary, since the returned array is either consisting of `string`s or of `fs.Dirent` objects, neither providing an asyncIterator. Refs: nodejs/help#3317 PR-URL: #38293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 parent 9fa7dcf commit b819848
Copy full SHA for b819848

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • fs.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/fs.md‎

Copy file name to clipboardExpand all lines: doc/api/fs.md

+1-1Lines changed: 1 addition & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -936,7 +936,7 @@ import { readdir } from 'fs/promises';
936	936
937	937	try {
938	938	const files = await readdir(path);
939		- for await (const file of files)
	939	+ for (const file of files)
940	940	console.log(file);
941	941	} catch (err) {
942	942	console.error(err);

0 commit comments

Comments

0 (0)