FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

events: inline createEvent hybrid dispatch closure · nodejs/node@b827c00 · GitHub

/ node Public

Commit b827c00

Browse files
authored andcommitted
events: inline createEvent hybrid dispatch closure
Originally added in 16b11cd, it first had three callers. Now there's only one branch requireing it. Signed-off-by: Szymon Łągiewka <slagiewka@users.noreply.github.com> PR-URL: #64473 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
1 parent 262f0ec commit b827c00

1 file changed

Lines changed: 6 additions & 9 deletions

File tree

‎lib/internal/event_target.js‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -791,14 +791,6 @@ class EventTarget {
791791
}
792792

793793
[kHybridDispatch](nodeValue, type, event) {
794-
const createEvent = () => {
795-
if (event === undefined) {
796-
event = this[kCreateEvent](nodeValue, type);
797-
event[kTarget] = this;
798-
event[kIsBeingDispatched] = true;
799-
}
800-
return event;
801-
};
802794
if (event !== undefined) {
803795
event[kTarget] = this;
804796
event[kIsBeingDispatched] = true;
@@ -844,7 +836,12 @@ class EventTarget {
844836
if (handler.isNodeStyleListener) {
845837
arg = nodeValue;
846838
} else {
847-
arg = createEvent();
839+
if (event === undefined) {
840+
event = this[kCreateEvent](nodeValue, type);
841+
event[kTarget] = this;
842+
event[kIsBeingDispatched] = true;
843+
}
844+
arg = event;
848845
}
849846
const callback = handler.weak ?
850847
handler.callback.deref() : handler.callback;

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL