Commit b833a59
n-api: use nullptr instead of NULL in node_api.cc
This commit changes two checks which use NULL to use nullptr.
I'm not very familiar with N-API but wanted to bring this up in case
it was something that was overlooked.
PR-URL: #17276
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: MichaëZasso <targos@protonmail.com>1 parent e45c9c6 commit b833a59
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1220,7 +1220,7 @@ napi_status napi_delete_property(napi_env env, | |||
| 1220 | 1220 | v8::Maybe<bool> delete_maybe = obj->Delete(context, k); | |
| 1221 | 1221 | CHECK_MAYBE_NOTHING(env, delete_maybe, napi_generic_failure); | |
| 1222 | 1222 | ||
| 1223 | - if (result != NULL) | ||
| 1223 | + if (result != nullptr) | ||
| 1224 | 1224 | *result = delete_maybe.FromMaybe(false); | |
| 1225 | 1225 | ||
| 1226 | 1226 | return GET_RETURN_STATUS(env); | |
@@ -1398,7 +1398,7 @@ napi_status napi_delete_element(napi_env env, | |||
| 1398 | 1398 | v8::Maybe<bool> delete_maybe = obj->Delete(context, index); | |
| 1399 | 1399 | CHECK_MAYBE_NOTHING(env, delete_maybe, napi_generic_failure); | |
| 1400 | 1400 | ||
| 1401 | - if (result != NULL) | ||
| 1401 | + if (result != nullptr) | ||
| 1402 | 1402 | *result = delete_maybe.FromMaybe(false); | |
| 1403 | 1403 | ||
| 1404 | 1404 | return GET_RETURN_STATUS(env); | |
0 commit comments