Commit b867294
child_process: remove unreachable execSync() code
Code coverage showed that the execSync() variable inheritStderr
was never set to the default value of true. This is because
the default case is hit whenever normalizeExecArgs() returns an
object without an 'options' property. However, this can never
be the case because normalizeExecArgs() unconditionally creates
the options object. This commit removes the unreachable code.
PR-URL: #9209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>1 parent 0cffa3c commit b867294
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -512,7 +512,7 @@ exports.execFileSync = execFileSync; | |||
| 512 | 512 | ||
| 513 | 513 | function execSync(command /*, options*/) { | |
| 514 | 514 | var opts = normalizeExecArgs.apply(null, arguments); | |
| 515 | - var inheritStderr = opts.options ? !opts.options.stdio : true; | ||
| 515 | + var inheritStderr = !opts.options.stdio; | ||
| 516 | 516 | ||
| 517 | 517 | var ret = spawnSync(opts.file, opts.options); | |
| 518 | 518 | ret.cmd = command; | |
0 commit comments