Commit b8ca616
test: fix compiler warnings in callback-scope
Currently there are two compiler warnings generated from the addons test
callback-scope:
../binding.cc:44:10:
warning: 'Resolve' is deprecated [-Wdeprecated-declarations]
local->Resolve(v8::Undefined(isolate));
^
../../../../deps/v8/include/v8.h:3893:45:
note: 'Resolve' has been explicitly marked deprecated here
V8_DEPRECATED("Use maybe version", void Resolve(Local<Value> value));
^
../binding.cc:52:54:
warning: 'New' is deprecated [-Wdeprecated-declarations]
persistent.Reset(isolate, v8::Promise::Resolver::New(isolate));
^
../../../../deps/v8/include/v8.h:3880:42:
note: 'New' has been explicitly marked deprecated here
Local<Resolver> New(Isolate* isolate));
This commit updates the test to use non-deprecated functions.
PR-URL: #19252
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent d3bc72e commit b8ca616
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -41,15 +41,17 @@ static void Callback(uv_work_t* req, int ignored) { | |||
| 41 | 41 | ||
| 42 | 42 | v8::Local<v8::Promise::Resolver> local = | |
| 43 | 43 | v8::Local<v8::Promise::Resolver>::New(isolate, persistent); | |
| 44 | - local->Resolve(v8::Undefined(isolate)); | ||
| 44 | + local->Resolve(isolate->GetCurrentContext(), | ||
| 45 | + v8::Undefined(isolate)).ToChecked(); | ||
| 45 | 46 | delete req; | |
| 46 | 47 | } | |
| 47 | 48 | ||
| 48 | 49 | static void TestResolveAsync(const v8::FunctionCallbackInfo<v8::Value>& args) { | |
| 49 | 50 | v8::Isolate* isolate = args.GetIsolate(); | |
| 50 | 51 | ||
| 51 | 52 | if (persistent.IsEmpty()) { | |
| 52 | - persistent.Reset(isolate, v8::Promise::Resolver::New(isolate)); | ||
| 53 | + persistent.Reset(isolate, v8::Promise::Resolver::New( | ||
| 54 | + isolate->GetCurrentContext()).ToLocalChecked()); | ||
| 53 | 55 | ||
| 54 | 56 | uv_work_t* req = new uv_work_t; | |
| 55 | 57 | ||
0 commit comments