Commit b8d145d
src: fix order of CHECK_NOT_NULL/dereference
`ASYNC_THROW_IF_INSUFFICIENT_PERMISSIONS` may dereference
`req_wrap_async`, so `CHECK_NOT_NULL(req_wrap_async)` should be used
before and not after.
PR-URL: #59487
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>1 parent 2a11d50 commit b8d145d
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1633,12 +1633,12 @@ static void Unlink(const FunctionCallbackInfo<Value>& args) { | |||
| 1633 | 1633 | ||
| 1634 | 1634 | if (argc > 1) { // unlink(path, req) | |
| 1635 | 1635 | FSReqBase* req_wrap_async = GetReqWrap(args, 1); | |
| 1636 | + CHECK_NOT_NULL(req_wrap_async); | ||
| 1636 | 1637 | ASYNC_THROW_IF_INSUFFICIENT_PERMISSIONS( | |
| 1637 | 1638 | env, | |
| 1638 | 1639 | req_wrap_async, | |
| 1639 | 1640 | permission::PermissionScope::kFileSystemWrite, | |
| 1640 | 1641 | path.ToStringView()); | |
| 1641 | - CHECK_NOT_NULL(req_wrap_async); | ||
| 1642 | 1642 | FS_ASYNC_TRACE_BEGIN1( | |
| 1643 | 1643 | UV_FS_UNLINK, req_wrap_async, "path", TRACE_STR_COPY(*path)) | |
| 1644 | 1644 | AsyncCall(env, req_wrap_async, args, "unlink", UTF8, AfterNoArgs, | |
0 commit comments