Commit b9d9ee4
src: make minor cleanups in encoding_binding.cc
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent f8acf2d commit b9d9ee4
1 file changed
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,10 +18,12 @@ using v8::BackingStore; | |||
| 18 | 18 | using v8::BackingStoreInitializationMode; | |
| 19 | 19 | using v8::Context; | |
| 20 | 20 | using v8::FunctionCallbackInfo; | |
| 21 | + using v8::HandleScope; | ||
| 21 | 22 | using v8::Isolate; | |
| 22 | 23 | using v8::Local; | |
| 23 | 24 | using v8::Object; | |
| 24 | 25 | using v8::ObjectTemplate; | |
| 26 | + using v8::SnapshotCreator; | ||
| 25 | 27 | using v8::String; | |
| 26 | 28 | using v8::Uint8Array; | |
| 27 | 29 | using v8::Value; | |
@@ -32,7 +34,7 @@ void BindingData::MemoryInfo(MemoryTracker* tracker) const { | |||
| 32 | 34 | } | |
| 33 | 35 | ||
| 34 | 36 | BindingData::BindingData(Realm* realm, | |
| 35 | - v8::Local<v8::Object> object, | ||
| 37 | + Local<Object> object, | ||
| 36 | 38 | InternalFieldInfo* info) | |
| 37 | 39 | : SnapshotableObject(realm, object, type_int), | |
| 38 | 40 | encode_into_results_buffer_( | |
@@ -52,7 +54,7 @@ BindingData::BindingData(Realm* realm, | |||
| 52 | 54 | } | |
| 53 | 55 | ||
| 54 | 56 | bool BindingData::PrepareForSerialization(Local<Context> context, | |
| 55 | - v8::SnapshotCreator* creator) { | ||
| 57 | + SnapshotCreator* creator) { | ||
| 56 | 58 | DCHECK_NULL(internal_field_info_); | |
| 57 | 59 | internal_field_info_ = InternalFieldInfoBase::New<InternalFieldInfo>(type()); | |
| 58 | 60 | internal_field_info_->encode_into_results_buffer = | |
@@ -74,7 +76,7 @@ void BindingData::Deserialize(Local<Context> context, | |||
| 74 | 76 | int index, | |
| 75 | 77 | InternalFieldInfoBase* info) { | |
| 76 | 78 | DCHECK_IS_SNAPSHOT_SLOT(index); | |
| 77 | - v8::HandleScope scope(context->GetIsolate()); | ||
| 79 | + HandleScope scope(context->GetIsolate()); | ||
| 78 | 80 | Realm* realm = Realm::GetCurrent(context); | |
| 79 | 81 | // Recreate the buffer in the constructor. | |
| 80 | 82 | InternalFieldInfo* casted_info = static_cast<InternalFieldInfo*>(info); | |
@@ -194,7 +196,7 @@ void BindingData::DecodeUTF8(const FunctionCallbackInfo<Value>& args) { | |||
| 194 | 196 | args.GetReturnValue().Set(ret); | |
| 195 | 197 | } | |
| 196 | 198 | ||
| 197 | - void BindingData::ToASCII(const v8::FunctionCallbackInfo<v8::Value>& args) { | ||
| 199 | + void BindingData::ToASCII(const FunctionCallbackInfo<Value>& args) { | ||
| 198 | 200 | Environment* env = Environment::GetCurrent(args); | |
| 199 | 201 | CHECK_GE(args.Length(), 1); | |
| 200 | 202 | CHECK(args[0]->IsString()); | |
@@ -207,7 +209,7 @@ void BindingData::ToASCII(const v8::FunctionCallbackInfo<v8::Value>& args) { | |||
| 207 | 209 | } | |
| 208 | 210 | } | |
| 209 | 211 | ||
| 210 | - void BindingData::ToUnicode(const v8::FunctionCallbackInfo<v8::Value>& args) { | ||
| 212 | + void BindingData::ToUnicode(const FunctionCallbackInfo<Value>& args) { | ||
| 211 | 213 | Environment* env = Environment::GetCurrent(args); | |
| 212 | 214 | CHECK_GE(args.Length(), 1); | |
| 213 | 215 | CHECK(args[0]->IsString()); | |
0 commit comments