Commit ba4abfd
deps: V8: cherry-pick 3e82c8d
Original commit message:
Fix check for V8_TARGET_OS_WIN macro
On Windows with MSVC, the current code triggers a fatal error C1017
(invalid integer constant expression).
Change-Id: I41c371a1d7909737052c03c830bb62c41154a192
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871918
Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64418}
Refs: v8/v8@3e82c8d
Backport-PR-URL: https://github.com/nodejs/node/pull/30513
PR-URL: https://github.com/nodejs/node/pull/30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 2abdcbb commit ba4abfd
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,7 @@ | |||
| 39 | 39 | ||
| 40 | 40 | # Reset this number to 0 on major V8 upgrades. | |
| 41 | 41 | # Increment by one for each non-official patch applied to deps/v8. | |
| 42 | - 'v8_embedder_string': '-node.9', | ||
| 42 | + 'v8_embedder_string': '-node.10', | ||
| 43 | 43 | ||
| 44 | 44 | ##### V8 defaults for Node.js ##### | |
| 45 | 45 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -102,7 +102,7 @@ class V8_EXPORT_PRIVATE TurboAssemblerBase : public Assembler { | |||
| 102 | 102 | static bool IsAddressableThroughRootRegister( | |
| 103 | 103 | Isolate* isolate, const ExternalReference& reference); | |
| 104 | 104 | ||
| 105 | - #if V8_TARGET_OS_WIN | ||
| 105 | + #ifdef V8_TARGET_OS_WIN | ||
| 106 | 106 | // Minimum page size. We must touch memory once per page when expanding the | |
| 107 | 107 | // stack, to avoid access violations. | |
| 108 | 108 | static constexpr int kStackPageSize = 4 * KB; | |
0 commit comments