Commit ba91ef2
fs: improve fsPromises writeFile performance
Increase the write chunk size in fsPromises writeFile
to improve performance.
PR-URL: #37610
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 2d9b624 commit ba91ef2
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,7 +6,7 @@ const kIoMaxLength = 2 ** 31 - 1; | |||
| 6 | 6 | ||
| 7 | 7 | const kReadFileBufferLength = 512 * 1024; | |
| 8 | 8 | const kReadFileUnknownBufferLength = 64 * 1024; | |
| 9 | - const kWriteFileMaxChunkSize = 2 ** 14; | ||
| 9 | + const kWriteFileMaxChunkSize = 512 * 1024; | ||
| 10 | 10 | ||
| 11 | 11 | const { | |
| 12 | 12 | ArrayPrototypePush, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -30,7 +30,7 @@ async function validateWriteFile() { | |||
| 30 | 30 | async function doWriteAndCancel() { | |
| 31 | 31 | const filePathForHandle = path.resolve(tmpDir, 'dogs-running.txt'); | |
| 32 | 32 | const fileHandle = await open(filePathForHandle, 'w+'); | |
| 33 | - const buffer = Buffer.from('dogs running'.repeat(10000), 'utf8'); | ||
| 33 | + const buffer = Buffer.from('dogs running'.repeat(512 * 1024), 'utf8'); | ||
| 34 | 34 | const controller = new AbortController(); | |
| 35 | 35 | const { signal } = controller; | |
| 36 | 36 | process.nextTick(() => controller.abort()); | |
0 commit comments