Commit bb0727a
test: do not run release-npm test without crypto
npm requires crypto support and cannot be loaded without it.
PR-URL: #30265
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>1 parent caedcd9 commit bb0727a
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,12 +7,13 @@ const path = require('path'); | |||
| 7 | 7 | ||
| 8 | 8 | const releaseReg = /^v\d+\.\d+\.\d+$/; | |
| 9 | 9 | ||
| 10 | - if (!releaseReg.test(process.version)) { | ||
| 10 | + // Npm requires crypto support. | ||
| 11 | + if (!releaseReg.test(process.version) || !common.hasCrypto) { | ||
| 11 | 12 | common.skip('This test is only for release builds'); | |
| 12 | 13 | } | |
| 13 | 14 | ||
| 14 | 15 | { | |
| 15 | - // Verify that npm does not print out a warning when executed | ||
| 16 | + // Verify that npm does not print out a warning when executed. | ||
| 16 | 17 | ||
| 17 | 18 | const npmCli = path.join(__dirname, '../../deps/npm/bin/npm-cli.js'); | |
| 18 | 19 | const npmExec = child_process.spawnSync(process.execPath, [npmCli]); | |
0 commit comments