Commit bb2977c
build: use glob for dependencies of out/Makefile
The `out/Makefile` target in `Makefile` has an incomplete list of
`.gyp` files for Node.js dependencies in `deps`, but also the ones
that are listed are unconditional. If using any of the `--shared-*`
configure options, it should be possible to still build Node.js if
the corresponding directory under `deps` is removed.
Convert the explicit list of dependency `*.gyp` files for the
`out/Makefile` target to a glob. This will pick up any toplevel
`.gyp` files for dependencies present in `deps`.
PR-URL: #55789
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent b08ce67 commit bb2977c
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -170,9 +170,9 @@ with-code-cache test-code-cache: | |||
| 170 | 170 | $(warning '$@' target is a noop) | |
| 171 | 171 | ||
| 172 | 172 | out/Makefile: config.gypi common.gypi node.gyp \ | |
| 173 | - deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \ | ||
| 174 | - deps/simdutf/simdutf.gyp deps/ada/ada.gyp \ | ||
| 175 | - tools/v8_gypfiles/toolchain.gypi tools/v8_gypfiles/features.gypi \ | ||
| 173 | + deps/*/*.gyp \ | ||
| 174 | + tools/v8_gypfiles/toolchain.gypi \ | ||
| 175 | + tools/v8_gypfiles/features.gypi \ | ||
| 176 | 176 | tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp | |
| 177 | 177 | $(PYTHON) tools/gyp_node.py -f make | |
| 178 | 178 | ||
0 commit comments