Commit bb57e90
src: remove base64 from process.versions
The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed
Refs: #52714
PR-URL: #53442
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent 561493d commit bb57e90
4 files changed
Lines changed: 1 addition & 11 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2,7 +2,6 @@ | |||
| 2 | 2 | #include "acorn_version.h" | |
| 3 | 3 | #include "ada.h" | |
| 4 | 4 | #include "ares.h" | |
| 5 | - #include "base64_version.h" | ||
| 6 | 5 | #include "brotli/encode.h" | |
| 7 | 6 | #include "cjs_module_lexer_version.h" | |
| 8 | 7 | #include "llhttp.h" | |
@@ -121,7 +120,6 @@ Metadata::Versions::Versions() { | |||
| 121 | 120 | ||
| 122 | 121 | acorn = ACORN_VERSION; | |
| 123 | 122 | cjs_module_lexer = CJS_MODULE_LEXER_VERSION; | |
| 124 | - base64 = BASE64_VERSION; | ||
| 125 | 123 | uvwasi = UVWASI_VERSION_STRING; | |
| 126 | 124 | ||
| 127 | 125 | #if HAVE_OPENSSL | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -49,8 +49,7 @@ namespace node { | |||
| 49 | 49 | V(simdutf) \ | |
| 50 | 50 | V(ada) \ | |
| 51 | 51 | NODE_VERSIONS_KEY_UNDICI(V) \ | |
| 52 | - V(cjs_module_lexer) \ | ||
| 53 | - V(base64) | ||
| 52 | + V(cjs_module_lexer) | ||
| 54 | 53 | ||
| 55 | 54 | #if HAVE_OPENSSL | |
| 56 | 55 | #define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -21,7 +21,6 @@ const expected_keys = [ | |||
| 21 | 21 | 'simdutf', | |
| 22 | 22 | 'ada', | |
| 23 | 23 | 'cjs_module_lexer', | |
| 24 | - 'base64', | ||
| 25 | 24 | ]; | |
| 26 | 25 | ||
| 27 | 26 | const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js'); | |
0 commit comments