Commit bb6787c
test: add check to test-fs-readfile-tostring-fail
Check that all of the bytes were written to the temporary file before
reading it to catch the case where there is insufficient disk space.
PR-URL: #43850
Refs: #43833
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent bb5511e commit bb6787c
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -25,13 +25,17 @@ stream.on('error', (err) => { throw err; }); | |||
| 25 | 25 | ||
| 26 | 26 | const size = kStringMaxLength / 200; | |
| 27 | 27 | const a = Buffer.alloc(size, 'a'); | |
| 28 | + let expectedSize = 0; | ||
| 28 | 29 | ||
| 29 | 30 | for (let i = 0; i < 201; i++) { | |
| 30 | - stream.write(a); | ||
| 31 | + stream.write(a, (err) => { assert.ifError(err); }); | ||
| 32 | + expectedSize += a.length; | ||
| 31 | 33 | } | |
| 32 | 34 | ||
| 33 | 35 | stream.end(); | |
| 34 | 36 | stream.on('finish', common.mustCall(function() { | |
| 37 | + assert.strictEqual(stream.bytesWritten, expectedSize, | ||
| 38 | + `${stream.bytesWritten} bytes written (expected ${expectedSize} bytes).`); | ||
| 35 | 39 | fs.readFile(file, 'utf8', common.mustCall(function(err, buf) { | |
| 36 | 40 | assert.ok(err instanceof Error); | |
| 37 | 41 | if (err.message !== 'Array buffer allocation failed') { | |
0 commit comments