Commit bb6f944
fs: add noop stub for FSWatcher.prototype.start
* Motivation: In a previous PR, #29905, I made this method a private
method since it had no value to the user.
There was discussion that maybe it should have been a runtime
deprecation first, but was ultimatley decided that for this
type of method, a noop stub was a better option.
This Adds back in the method, but as a noop stub, while also keeping
the real implementation private
PR-URL: #30160
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent e51beef commit bb6f944
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -174,6 +174,12 @@ FSWatcher.prototype[kFSWatchStart] = function(filename, | |||
| 174 | 174 | } | |
| 175 | 175 | }; | |
| 176 | 176 | ||
| 177 | + // To maximize backward-compatiblity for the end user, | ||
| 178 | + // a no-op stub method has been added instead of | ||
| 179 | + // totally removing FSWatcher.prototpye.start. | ||
| 180 | + // This should not be documented. | ||
| 181 | + FSWatcher.prototype.start = () => {}; | ||
| 182 | + | ||
| 177 | 183 | // This method is a noop if the watcher has not been started or | |
| 178 | 184 | // has already been closed. | |
| 179 | 185 | FSWatcher.prototype.close = function() { | |
0 commit comments