http2: track nghttp2-allocated memory in heap snapshot · nodejs/node@bb77e6e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 753
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bb77e6e

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

targos

committed

http2: track nghttp2-allocated memory in heap snapshot

PR-URL: #30745 Refs: https://github.com/nodejs/quic/blob/34ee0bc96f804c73cb22b2945a1a78f780938492/src/node_mem.h Refs: nodejs/quic#126 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 284f033 commit bb77e6e
Copy full SHA for bb77e6e

2 files changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_http2.h
• test/pummel
  • test-heapdump-http2.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_http2.h‎

Copy file name to clipboardExpand all lines: src/node_http2.h

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -794,6 +794,7 @@ class Http2Session : public AsyncWrap,
794	794	tracker->TrackFieldWithSize("outgoing_storage", outgoing_storage_.size());
795	795	tracker->TrackFieldWithSize("pending_rst_streams",
796	796	pending_rst_streams_.size() * sizeof(int32_t));
	797	+ tracker->TrackFieldWithSize("nghttp2_memory", current_nghttp2_memory_);
797	798	}
798	799
799	800	SET_MEMORY_INFO_NAME(Http2Session)

Collapse file

‎test/pummel/test-heapdump-http2.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-heapdump-http2.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -69,6 +69,7 @@ server.listen(0, () => {
69	69	{
70	70	children: [
71	71	{ node_name: 'Http2Session', edge_name: 'wrapped' },
	72	+ { node_name: 'Node / nghttp2_memory', edge_name: 'nghttp2_memory' },
72	73	{
73	74	node_name: 'Node / streams', edge_name: 'streams'
74	75	}

0 commit comments

Comments

0 (0)