lib: use <array>.push and <array>.unshift instead of <array>.concat · nodejs/node@bb81acc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bb81acc

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

targos

committed

lib: use <array>.push and <array>.unshift instead of <array>.concat

Using `push` and `unshift` methods is more performant than reassigning a new array created with `concat`. PR-URL: #37239 Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent a3e3156 commit bb81acc
Copy full SHA for bb81acc

3 files changed

+8-7Lines changed: 8 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _http_common.js
  • internal
    • main
      • worker_thread.js
    • modules/cjs
      • loader.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_http_common.js‎

Copy file name to clipboardExpand all lines: lib/_http_common.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -22,7 +22,7 @@
22	22	'use strict';
23	23
24	24	const {
25		- ArrayPrototypeConcat,
	25	+ ArrayPrototypePushApply,
26	26	MathMin,
27	27	Symbol,
28	28	RegExpPrototypeTest,
@@ -66,7 +66,7 @@ function parserOnHeaders(headers, url) {
66	66	// Once we exceeded headers limit - stop collecting them
67	67	if (this.maxHeaderPairs <= 0 ||
68	68	this._headers.length < this.maxHeaderPairs) {
69		- this._headers = ArrayPrototypeConcat(this._headers, headers);
	69	+ ArrayPrototypePushApply(this._headers, headers);
70	70	}
71	71	this._url += url;
72	72	}

Collapse file

‎lib/internal/main/worker_thread.js‎

Copy file name to clipboardExpand all lines: lib/internal/main/worker_thread.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -4,8 +4,8 @@
4	4	// message port.
5	5
6	6	const {
7		- ArrayPrototypeConcat,
8	7	ArrayPrototypeForEach,
	8	+ ArrayPrototypePushApply,
9	9	ArrayPrototypeSplice,
10	10	ObjectDefineProperty,
11	11	PromisePrototypeCatch,
@@ -126,7 +126,7 @@ port.on('message', (message) => {
126	126	loadPreloadModules();
127	127	initializeFrozenIntrinsics();
128	128	if (argv !== undefined) {
129		- process.argv = ArrayPrototypeConcat(process.argv, argv);
	129	+ ArrayPrototypePushApply(process.argv, argv);
130	130	}
131	131	publicWorker.parentPort = publicPort;
132	132	publicWorker.workerData = workerData;

Collapse file

‎lib/internal/modules/cjs/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/cjs/loader.js

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -32,6 +32,7 @@ const {
32	32	ArrayPrototypeSlice,
33	33	ArrayPrototypeSplice,
34	34	ArrayPrototypeUnshift,
	35	+ ArrayPrototypeUnshiftApply,
35	36	Boolean,
36	37	Error,
37	38	JSONParse,
@@ -1208,18 +1209,18 @@ Module._initPaths = function() {
1208	1209	path.resolve(process.execPath, '..') :
1209	1210	path.resolve(process.execPath, '..', '..');
1210	1211
1211		- let paths = [path.resolve(prefixDir, 'lib', 'node')];
	1212	+ const paths = [path.resolve(prefixDir, 'lib', 'node')];
1212	1213
1213	1214	if (homeDir) {
1214	1215	ArrayPrototypeUnshift(paths, path.resolve(homeDir, '.node_libraries'));
1215	1216	ArrayPrototypeUnshift(paths, path.resolve(homeDir, '.node_modules'));
1216	1217	}
1217	1218
1218	1219	if (nodePath) {
1219		- paths = ArrayPrototypeConcat(ArrayPrototypeFilter(
	1220	+ ArrayPrototypeUnshiftApply(paths, ArrayPrototypeFilter(
1220	1221	StringPrototypeSplit(nodePath, path.delimiter),
1221	1222	Boolean
1222		- ), paths);
	1223	+ ));
1223	1224	}
1224	1225
1225	1226	modulePaths = paths;

0 commit comments

Comments

0 (0)