benchmark: fix api restriction for the permission category · nodejs/node@bb844de · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bb844de

Browse filesBrowse the repository at this point in the historyBrowse files

bekcpear

authored and

targos

committed

benchmark: fix api restriction for the permission category

give appropriate permissions to the following scripts: * permission-processhas-fs-read.js: 'ChildProcess' permission * permission-startup.js: 'FileSystemRead' permission > Paths delimited by comma (,) are no longer allowed. Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read Signed-off-by: Ryan Qian <i@bitbili.net> PR-URL: #51528 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 6d8589e commit bb844de
Copy full SHA for bb844de

2 files changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• benchmark/permission
  • permission-processhas-fs-read.js
  • permission-startup.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎benchmark/permission/permission-processhas-fs-read.js‎

Copy file name to clipboardExpand all lines: benchmark/permission/permission-processhas-fs-read.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -13,6 +13,7 @@ const options = {
13	13	flags: [
14	14	'--experimental-permission',
15	15	`--allow-fs-read=${rootPath}`,
	16	+ '--allow-child-process',
16	17	],
17	18	};
18	19

Collapse file

‎benchmark/permission/permission-startup.js‎

Copy file name to clipboardExpand all lines: benchmark/permission/permission-startup.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -47,10 +47,10 @@ function spawnProcess(script, bench, state) {
47	47
48	48	function main({ count, script, nFiles, prefixPath }) {
49	49	script = path.resolve(__dirname, '../../', `${script}.js`);
50		- const files = mockFiles(nFiles, prefixPath).join(',');
51	50	const optionsWithScript = [
52	51	'--experimental-permission',
53		- `--allow-fs-read=${files},${script}`,
	52	+ `--allow-fs-read=${script}`,
	53	+ ...mockFiles(nFiles, prefixPath).map((file) => '--allow-fs-read=' + file),
54	54	script,
55	55	];
56	56	const warmup = 3;

0 commit comments

Comments

0 (0)