Commit bbcf9f0
benchmark: swap var for let in buffer benchmarks
In benchmark buffers directory this changes for loops using var to let
when it applies for consistency
PR-URL: #28867
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent f2c1f36 commit bbcf9f0
18 files changed
Lines changed: 25 additions & 25 deletions
File tree
- benchmark/buffers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,7 +18,7 @@ function main({ charsPerLine, linesCount, n }) { | |||
| 18 | 18 | const buffer = Buffer.alloc(bytesCount, line, 'base64'); | |
| 19 | 19 | ||
| 20 | 20 | bench.start(); | |
| 21 | - for (var i = 0; i < n; i++) { | ||
| 21 | + for (let i = 0; i < n; i++) { | ||
| 22 | 22 | buffer.base64Write(data, 0, bytesCount); | |
| 23 | 23 | } | |
| 24 | 24 | bench.end(n); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -16,6 +16,6 @@ function main({ n, size }) { | |||
| 16 | 16 | const b = Buffer.allocUnsafe(encodedSize); | |
| 17 | 17 | b.write(s, 0, encodedSize, 'base64'); | |
| 18 | 18 | bench.start(); | |
| 19 | - for (var i = 0; i < n; i += 1) b.base64Write(s, 0, s.length); | ||
| 19 | + for (let i = 0; i < n; i += 1) b.base64Write(s, 0, s.length); | ||
| 20 | 20 | bench.end(n); | |
| 21 | 21 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ function main({ n, len, encoding }) { | |||
| 37 | 37 | } | |
| 38 | 38 | ||
| 39 | 39 | bench.start(); | |
| 40 | - for (var i = 0; i < n; i++) { | ||
| 40 | + for (let i = 0; i < n; i++) { | ||
| 41 | 41 | const index = n % strings.length; | |
| 42 | 42 | // Go! | |
| 43 | 43 | const r = Buffer.byteLength(strings[index], encoding); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,12 +8,12 @@ const bench = common.createBenchmark(main, { | |||
| 8 | 8 | }); | |
| 9 | 9 | ||
| 10 | 10 | function compareUsingSlice(b0, b1, len, iter) { | |
| 11 | - for (var i = 0; i < iter; i++) | ||
| 11 | + for (let i = 0; i < iter; i++) | ||
| 12 | 12 | Buffer.compare(b0.slice(1, len), b1.slice(1, len)); | |
| 13 | 13 | } | |
| 14 | 14 | ||
| 15 | 15 | function compareUsingOffset(b0, b1, len, iter) { | |
| 16 | - for (var i = 0; i < iter; i++) | ||
| 16 | + for (let i = 0; i < iter; i++) | ||
| 17 | 17 | b0.compare(b1, 1, len, 1, len); | |
| 18 | 18 | } | |
| 19 | 19 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -34,7 +34,7 @@ function main({ n, size }) { | |||
| 34 | 34 | b1[size - 1] = 'b'.charCodeAt(0); | |
| 35 | 35 | ||
| 36 | 36 | bench.start(); | |
| 37 | - for (var i = 0; i < n; i++) { | ||
| 37 | + for (let i = 0; i < n; i++) { | ||
| 38 | 38 | Buffer.compare(b0, b1); | |
| 39 | 39 | } | |
| 40 | 40 | bench.end(n); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,7 +15,7 @@ function main({ n, pieces, pieceSize, withTotalLength }) { | |||
| 15 | 15 | const totalLength = withTotalLength ? pieces * pieceSize : undefined; | |
| 16 | 16 | ||
| 17 | 17 | bench.start(); | |
| 18 | - for (var i = 0; i < n; i++) { | ||
| 18 | + for (let i = 0; i < n; i++) { | ||
| 19 | 19 | Buffer.concat(list, totalLength); | |
| 20 | 20 | } | |
| 21 | 21 | bench.end(n); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,7 +15,7 @@ function main({ n, value }) { | |||
| 15 | 15 | ||
| 16 | 16 | let count = 0; | |
| 17 | 17 | bench.start(); | |
| 18 | - for (var i = 0; i < n; i++) { | ||
| 18 | + for (let i = 0; i < n; i++) { | ||
| 19 | 19 | count += aliceBuffer.indexOf(value, 0, undefined); | |
| 20 | 20 | } | |
| 21 | 21 | bench.end(n); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -42,7 +42,7 @@ function main({ n, search, encoding, type }) { | |||
| 42 | 42 | } | |
| 43 | 43 | ||
| 44 | 44 | bench.start(); | |
| 45 | - for (var i = 0; i < n; i++) { | ||
| 45 | + for (let i = 0; i < n; i++) { | ||
| 46 | 46 | aliceBuffer.indexOf(search, 0, encoding); | |
| 47 | 47 | } | |
| 48 | 48 | bench.end(n); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -31,7 +31,7 @@ function main({ encoding, n }) { | |||
| 31 | 31 | const { normalizeEncoding } = require('internal/util'); | |
| 32 | 32 | ||
| 33 | 33 | bench.start(); | |
| 34 | - for (var i = 0; i < n; i++) { | ||
| 34 | + for (let i = 0; i < n; i++) { | ||
| 35 | 35 | normalizeEncoding(encoding); | |
| 36 | 36 | } | |
| 37 | 37 | bench.end(n); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -32,7 +32,7 @@ function main({ n, type, endian, value }) { | |||
| 32 | 32 | buff[`write${type}${endian}`](values[type][value], 0); | |
| 33 | 33 | ||
| 34 | 34 | bench.start(); | |
| 35 | - for (var i = 0; i !== n; i++) { | ||
| 35 | + for (let i = 0; i !== n; i++) { | ||
| 36 | 36 | buff[fn](0); | |
| 37 | 37 | } | |
| 38 | 38 | bench.end(n); | |
0 commit comments