Commit bbed1e5
deps: V8: cherry-pick e1eac1b16c96
Original commit message:
Fix compilation error with devtoolset-8
We are compiling V8 using devtoolset-8 and it is generating a new
compilation error related to String Truncation:
error: ‘char* strncpy(char*, const char*, size_t)’ output truncated copying between 1 and 15 bytes from a string of length 15 [-Werror=stringop-truncation]
strncpy(buffer, unicode_utf8, i);
Which basically means the null terminating character was not added to
the end of the buffer:
https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/
This CL will changes 2 uses of "strncpy" to "memcpy" as strings
are being copied partially and `\n` being added at a later stage.
Change-Id: I3656afb00463d70ddb8700a487a1978b793e1d09
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2155038
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#67277}
Refs: v8/v8@e1eac1b
PR-URL: #32974
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>1 parent 7647860 commit bbed1e5
2 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,7 +35,7 @@ | |||
| 35 | 35 | ||
| 36 | 36 | # Reset this number to 0 on major V8 upgrades. | |
| 37 | 37 | # Increment by one for each non-official patch applied to deps/v8. | |
| 38 | - 'v8_embedder_string': '-node.30', | ||
| 38 | + 'v8_embedder_string': '-node.31', | ||
| 39 | 39 | ||
| 40 | 40 | ##### V8 defaults for Node.js ##### | |
| 41 | 41 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -331,8 +331,8 @@ TEST(Utf8AdvanceUntilOverChunkBoundaries) { | |||
| 331 | 331 | for (size_t i = 1; i < len; i++) { | |
| 332 | 332 | // Copy source string into buffer, splitting it at i. | |
| 333 | 333 | // Then add three chunks, 0..i-1, i..strlen-1, empty. | |
| 334 | - strncpy(buffer, unicode_utf8, i); | ||
| 335 | - strncpy(buffer + i + 1, unicode_utf8 + i, len - i); | ||
| 334 | + memcpy(buffer, unicode_utf8, i); | ||
| 335 | + memcpy(buffer + i + 1, unicode_utf8 + i, len - i); | ||
| 336 | 336 | buffer[i] = '\0'; | |
| 337 | 337 | buffer[len + 1] = '\n'; | |
| 338 | 338 | buffer[len + 2] = '\0'; | |
@@ -360,8 +360,8 @@ TEST(Utf8ChunkBoundaries) { | |||
| 360 | 360 | for (size_t i = 1; i < len; i++) { | |
| 361 | 361 | // Copy source string into buffer, splitting it at i. | |
| 362 | 362 | // Then add three chunks, 0..i-1, i..strlen-1, empty. | |
| 363 | - strncpy(buffer, unicode_utf8, i); | ||
| 364 | - strncpy(buffer + i + 1, unicode_utf8 + i, len - i); | ||
| 363 | + memcpy(buffer, unicode_utf8, i); | ||
| 364 | + memcpy(buffer + i + 1, unicode_utf8 + i, len - i); | ||
| 365 | 365 | buffer[i] = '\0'; | |
| 366 | 366 | buffer[len + 1] = '\0'; | |
| 367 | 367 | buffer[len + 2] = '\0'; | |
0 commit comments