Commit bc755fc
src: fix compiler warnings in node_http2.cc
Currently, the following compiler warnings are generated:
../src/node_http2.cc: In static member function
‘static int node::http2::Http2Session::OnStreamClose(nghttp2_session*,
int32_t, uint32_t, void*)’:
../src/node_http2.cc:994:16: warning:
variable ‘def’ set but not used [-Wunused-but-set-variable]
994 | Local<Value> def = v8::False(env->isolate());
| ^~~
../src/node_http2.cc: In static member function
‘static void node::http2::Http2Session::Ping(
const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_http2.cc:2755:16: warning:
unused variable ‘env’ [-Wunused-variable]
2755 | Environment* env = Environment::GetCurrent(args);
| ^~~
../src/node_http2.cc: In static member function
‘static void node::http2::Http2Session::Settings(
const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_http2.cc:2774:16: warning:
unused variable ‘env’ [-Wunused-variable]
2774 | Environment* env = Environment::GetCurrent(args);
| ^~~
This commit removes these unused variables.
PR-URL: #33014
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>1 parent 4c10b5f commit bc755fc
1 file changed
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -991,7 +991,6 @@ int Http2Session::OnStreamClose(nghttp2_session* handle, | |||
| 991 | 991 | MaybeLocal<Value> answer = | |
| 992 | 992 | stream->MakeCallback(env->http2session_on_stream_close_function(), | |
| 993 | 993 | 1, &arg); | |
| 994 | - Local<Value> def = v8::False(env->isolate()); | ||
| 995 | 994 | if (answer.IsEmpty() || answer.ToLocalChecked()->IsFalse()) { | |
| 996 | 995 | // Skip to destroy | |
| 997 | 996 | stream->Destroy(); | |
@@ -2752,7 +2751,6 @@ void Http2Session::Origin(const FunctionCallbackInfo<Value>& args) { | |||
| 2752 | 2751 | ||
| 2753 | 2752 | // Submits a PING frame to be sent to the connected peer. | |
| 2754 | 2753 | void Http2Session::Ping(const FunctionCallbackInfo<Value>& args) { | |
| 2755 | - Environment* env = Environment::GetCurrent(args); | ||
| 2756 | 2754 | Http2Session* session; | |
| 2757 | 2755 | ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder()); | |
| 2758 | 2756 | ||
@@ -2771,7 +2769,6 @@ void Http2Session::Ping(const FunctionCallbackInfo<Value>& args) { | |||
| 2771 | 2769 | ||
| 2772 | 2770 | // Submits a SETTINGS frame for the Http2Session | |
| 2773 | 2771 | void Http2Session::Settings(const FunctionCallbackInfo<Value>& args) { | |
| 2774 | - Environment* env = Environment::GetCurrent(args); | ||
| 2775 | 2772 | Http2Session* session; | |
| 2776 | 2773 | ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder()); | |
| 2777 | 2774 | CHECK(args[0]->IsFunction()); | |
0 commit comments