src: remove duplicated code in `GenerateSingleExecutableBlob()` · nodejs/node@bceaec3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 559
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bceaec3

Browse filesBrowse the repository at this point in the historyBrowse files

Jungku Lee

authored and

RafaelGSS

committed

src: remove duplicated code in GenerateSingleExecutableBlob()

PR-URL: #49119 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

1 parent 324c8a1 commit bceaec3
Copy full SHA for bceaec3

1 file changed

-7Lines changed: 0 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_sea.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_sea.cc‎

Copy file name to clipboardExpand all lines: src/node_sea.cc

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -486,13 +486,6 @@ ExitCode GenerateSingleExecutableBlob(
486	486	}
487	487	}
488	488
489		- std::optional<std::string> optional_code_cache =
490		- GenerateCodeCache(config.main_path, main_script);
491		- if (!optional_code_cache.has_value()) {
492		- FPrintF(stderr, "Cannot generate V8 code cache\n");
493		- return ExitCode::kGenericUserError;
494		- }
495		-
496	489	std::optional<std::string_view> optional_sv_code_cache;
497	490	std::string code_cache;
498	491	if (static_cast<bool>(config.flags & SeaFlags::kUseCodeCache)) {

0 commit comments

Comments

0 (0)