bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder · nodejs/node@bd27b8b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bd27b8b

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

danielleadams

committed

bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder

To improve startup performance. PR-URL: #44104 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent f461d79 commit bd27b8b
Copy full SHA for bd27b8b

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_snapshotable.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_snapshotable.cc‎

Copy file name to clipboardExpand all lines: src/node_snapshotable.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1014,7 +1014,7 @@ int SnapshotBuilder::Generate(SnapshotData* out,
1014	1014
1015	1015	// Must be out of HandleScope
1016	1016	out->v8_snapshot_blob_data =
1017		- creator.CreateBlob(SnapshotCreator::FunctionCodeHandling::kClear);
	1017	+ creator.CreateBlob(SnapshotCreator::FunctionCodeHandling::kKeep);
1018	1018
1019	1019	// We must be able to rehash the blob when we restore it or otherwise
1020	1020	// the hash seed would be fixed by V8, introducing a vulnerability.

0 commit comments

Comments

0 (0)