Commit bd380d5
src: improve node_crypto.cc memory allocation
This avoids heap allocations in common cases
PR-URL: #30751
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 19eb8e0 commit bd380d5
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2700,11 +2700,11 @@ void SSLWrap<Base>::GetSharedSigalgs(const FunctionCallbackInfo<Value>& args) { | |||
| 2700 | 2700 | Base* w; | |
| 2701 | 2701 | ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); | |
| 2702 | 2702 | Environment* env = w->ssl_env(); | |
| 2703 | - std::vector<Local<Value>> ret_arr; | ||
| 2704 | 2703 | ||
| 2705 | 2704 | SSL* ssl = w->ssl_.get(); | |
| 2706 | 2705 | int nsig = SSL_get_shared_sigalgs(ssl, 0, nullptr, nullptr, nullptr, nullptr, | |
| 2707 | 2706 | nullptr); | |
| 2707 | + MaybeStackBuffer<Local<Value>, 16> ret_arr(nsig); | ||
| 2708 | 2708 | ||
| 2709 | 2709 | for (int i = 0; i < nsig; i++) { | |
| 2710 | 2710 | int hash_nid; | |
@@ -2768,12 +2768,11 @@ void SSLWrap<Base>::GetSharedSigalgs(const FunctionCallbackInfo<Value>& args) { | |||
| 2768 | 2768 | } else { | |
| 2769 | 2769 | sig_with_md += "UNDEF"; | |
| 2770 | 2770 | } | |
| 2771 | - | ||
| 2772 | - ret_arr.push_back(OneByteString(env->isolate(), sig_with_md.c_str())); | ||
| 2771 | + ret_arr[i] = OneByteString(env->isolate(), sig_with_md.c_str()); | ||
| 2773 | 2772 | } | |
| 2774 | 2773 | ||
| 2775 | 2774 | args.GetReturnValue().Set( | |
| 2776 | - Array::New(env->isolate(), ret_arr.data(), ret_arr.size())); | ||
| 2775 | + Array::New(env->isolate(), ret_arr.out(), ret_arr.length())); | ||
| 2777 | 2776 | } | |
| 2778 | 2777 | ||
| 2779 | 2778 | ||
0 commit comments