Commit bd7822b
test: make test-error-reporting engine agnostic
Remove or modify checks in test-error-reporting that only apply to V8
and not to ChakraCore.
PR-URL: #16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 4604294 commit bd7822b
1 file changed
Lines changed: 2 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -32,17 +32,14 @@ function errExec(script, callback) { | |||
| 32 | 32 | assert.ok(err); | |
| 33 | 33 | ||
| 34 | 34 | // More than one line of error output. | |
| 35 | - assert.ok(stderr.split('\n').length > 2); | ||
| 36 | - | ||
| 37 | - // Assert the script is mentioned in error output. | ||
| 38 | - assert.ok(stderr.includes(script)); | ||
| 35 | + assert.ok(stderr.split('\n').length); | ||
| 39 | 36 | ||
| 40 | 37 | // Proxy the args for more tests. | |
| 41 | 38 | callback(err, stdout, stderr); | |
| 42 | 39 | }); | |
| 43 | 40 | } | |
| 44 | 41 | ||
| 45 | - const syntaxErrorMessage = /SyntaxError/; | ||
| 42 | + const syntaxErrorMessage = /\bSyntaxError\b/; | ||
| 46 | 43 | ||
| 47 | 44 | ||
| 48 | 45 | // Simple throw error | |
@@ -65,7 +62,6 @@ errExec('throws_error3.js', common.mustCall(function(err, stdout, stderr) { | |||
| 65 | 62 | ||
| 66 | 63 | // throw ILLEGAL error | |
| 67 | 64 | errExec('throws_error4.js', common.mustCall(function(err, stdout, stderr) { | |
| 68 | - assert.ok(/\/\*\*/.test(stderr)); | ||
| 69 | 65 | assert.ok(syntaxErrorMessage.test(stderr)); | |
| 70 | 66 | })); | |
| 71 | 67 | ||
0 commit comments