test: replace Map with Array in cluster-net-listen tests · nodejs/node@bdcc11f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 636
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bdcc11f

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

MylesBorins

committed

test: replace Map with Array in cluster-net-listen tests

PR-URL: #32381 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 85bdb42 commit bdcc11f
Copy full SHA for bdcc11f

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/sequential
  • test-cluster-net-listen-ipv6only-none.js
  • test-cluster-net-listen-ipv6only-rr.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/sequential/test-cluster-net-listen-ipv6only-none.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-cluster-net-listen-ipv6only-none.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -16,7 +16,7 @@ const host = '::';
16	16	const WORKER_ACCOUNT = 3;
17	17
18	18	if (cluster.isMaster) {
19		- const workers = new Map();
	19	+ const workers = [];
20	20
21	21	const countdown = new Countdown(WORKER_ACCOUNT, () => {
22	22	// Make sure the `ipv6Only` option works. This is the part of the test that
@@ -46,7 +46,7 @@ if (cluster.isMaster) {
46	46	countdown.dec();
47	47	}));
48	48
49		- workers.set(i, worker);
	49	+ workers[i] = worker;
50	50	}
51	51	} else {
52	52	net.createServer().listen({

Collapse file

‎test/sequential/test-cluster-net-listen-ipv6only-rr.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-cluster-net-listen-ipv6only-rr.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -16,7 +16,7 @@ const host = '::';
16	16	const WORKER_ACCOUNT = 3;
17	17
18	18	if (cluster.isMaster) {
19		- const workers = new Map();
	19	+ const workers = [];
20	20	let address;
21	21
22	22	const countdown = new Countdown(WORKER_ACCOUNT, () => {
@@ -45,7 +45,7 @@ if (cluster.isMaster) {
45	45	countdown.dec();
46	46	}));
47	47
48		- workers.set(i, worker);
	48	+ workers[i] = worker;
49	49	}
50	50	} else {
51	51	// As the cluster member has the potential to grab any port

0 commit comments

Comments

0 (0)