Commit be16cc9
test: set umask for tests
#25213 proposes setting umask in the
Python test runner to avoid spurious test failures when running from a
shell with a restrictive umask. This is a good idea, but will only fix
the issue for tests run with the Python runner. Set it in
`common/index.js` as well so that it fixes it even when tests are run
directly with a `node` binary, bypassing the Python test runner.
PR-URL: #25229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 3bebcf0 commit be16cc9
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -34,6 +34,14 @@ const { | |||
| 34 | 34 | hasIntl | |
| 35 | 35 | } = process.binding('config'); | |
| 36 | 36 | ||
| 37 | + // Some tests assume a umask of 0o022 so set that up front. Tests that need a | ||
| 38 | + // different umask will set it themselves. | ||
| 39 | + // | ||
| 40 | + // process.umask() is not available in workers so we need to check for its | ||
| 41 | + // existence. | ||
| 42 | + if (process.umask) | ||
| 43 | + process.umask(0o022); | ||
| 44 | + | ||
| 37 | 45 | const noop = () => {}; | |
| 38 | 46 | ||
| 39 | 47 | const hasCrypto = Boolean(process.versions.openssl); | |
0 commit comments