Commit bec959e
tools: disable LTO for "v8_cppgc_shared" target
"PushAllRegistersAndIterateStack" is implemented in assembly and
called from "stack.cc" via 'extern "C"'. [1]
However, LTO does not work well with symbol usage from assembly. [2]
This change workarounds the issue by disabling LTO for the target.
With GCC 10 and "./configure --enable-lto", compilation succeeds
after this change.
[1] v8/v8@c10863153
[2] https://gcc.gnu.org/wiki/LinkTimeOptimizationFAQ#Symbol_usage_from_assembly_language
Refs: #35957
Refs: #38335
Signed-off-by: Jesse Chan <jc@linux.com>
PR-URL: #38346
Refs: #35957
Refs: #38335
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>1 parent 3cbfde1 commit bec959e
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1378,6 +1378,9 @@ | |||
| 1378 | 1378 | '<(V8_ROOT)/src/heap/base/worklist.h', | |
| 1379 | 1379 | ], | |
| 1380 | 1380 | 'conditions': [ | |
| 1381 | + ['enable_lto=="true"', { | ||
| 1382 | + 'cflags_cc': [ '-fno-lto' ], | ||
| 1383 | + }], | ||
| 1381 | 1384 | ['clang or OS!="win"', { | |
| 1382 | 1385 | 'conditions': [ | |
| 1383 | 1386 | ['_toolset == "host" and host_arch == "x64" or _toolset == "target" and target_arch=="x64"', { | |
0 commit comments