Commit bf4ac4c
net: remove redundant connecting assignment
PR-URL: #43710
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>1 parent 5a5c4be commit bf4ac4c
2 files changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1239,7 +1239,6 @@ function afterConnect(status, handle, req, readable, writable) { | |||
| 1239 | 1239 | stopPerf(self, kPerfHooksNetConnectContext); | |
| 1240 | 1240 | } | |
| 1241 | 1241 | } else { | |
| 1242 | - self.connecting = false; | ||
| 1243 | 1242 | let details; | |
| 1244 | 1243 | if (req.localAddress && req.localPort) { | |
| 1245 | 1244 | details = req.localAddress + ':' + req.localPort; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,5 +27,6 @@ const assert = require('assert'); | |||
| 27 | 27 | const c = net.createConnection(common.PORT); | |
| 28 | 28 | c.on('connect', common.mustNotCall()); | |
| 29 | 29 | c.on('error', common.mustCall((e) => { | |
| 30 | + assert.strictEqual(c.connecting, false); | ||
| 30 | 31 | assert.strictEqual(e.code, 'ECONNREFUSED'); | |
| 31 | 32 | })); | |
0 commit comments