Commit bf56dec
benchmark: fix async-resource benchmark
In the benchmark, because it performs asynchronous operations before
writing its HTTP replies, the underlying socket can be closed by the
peer before the response is written. Since 28e6626, that means
that attempting to `.end()` the HTTP response results in an uncaught
exception, breaking the benchmark.
Fix that by checking whether the response object has been destroyed
or not before attempting to call `.end()`.
#33591
PR-URL: #33642
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent 9fb1eb0 commit bf56dec
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -138,6 +138,7 @@ function getServeAwait(getCLS, setCLS) { | |||
| 138 | 138 | setCLS(Math.random()); | |
| 139 | 139 | await sleep(10); | |
| 140 | 140 | await read(__filename); | |
| 141 | + if (res.destroyed) return; | ||
| 141 | 142 | res.setHeader('content-type', 'application/json'); | |
| 142 | 143 | res.end(JSON.stringify({ cls: getCLS() })); | |
| 143 | 144 | }; | |
@@ -148,6 +149,7 @@ function getServeCallbacks(getCLS, setCLS) { | |||
| 148 | 149 | setCLS(Math.random()); | |
| 149 | 150 | setTimeout(() => { | |
| 150 | 151 | readFile(__filename, () => { | |
| 152 | + if (res.destroyed) return; | ||
| 151 | 153 | res.setHeader('content-type', 'application/json'); | |
| 152 | 154 | res.end(JSON.stringify({ cls: getCLS() })); | |
| 153 | 155 | }); | |
0 commit comments