src: mark internally exported functions as explicitly internal · nodejs/node@bf79987 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bf79987

Browse filesBrowse the repository at this point in the historyBrowse files

implausible

authored and

jasnell

committed

src: mark internally exported functions as explicitly internal

PR-URL: #37000 Fixes: #36349 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 1fe571a commit bf79987
Copy full SHA for bf79987

2 files changed

+10-6Lines changed: 10 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • api
    • hooks.cc
  • node.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/api/hooks.cc‎

Copy file name to clipboardExpand all lines: src/api/hooks.cc

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -145,7 +145,7 @@ static void RunAsyncCleanupHook(void* arg) {
145	145	info->fun(info->arg, FinishAsyncCleanupHook, info);
146	146	}
147	147
148		- ACHHandle* AddEnvironmentCleanupHookRaw(
	148	+ ACHHandle* AddEnvironmentCleanupHookInternal(
149	149	Isolate* isolate,
150	150	AsyncCleanupHook fun,
151	151	void* arg) {
@@ -160,7 +160,7 @@ ACHHandle* AddEnvironmentCleanupHookRaw(
160	160	return new ACHHandle { info };
161	161	}
162	162
163		- void RemoveEnvironmentCleanupHookRaw(
	163	+ void RemoveEnvironmentCleanupHookInternal(
164	164	ACHHandle* handle) {
165	165	if (handle->info->started) return;
166	166	handle->info->self.reset();

Collapse file

‎src/node.h‎

Copy file name to clipboardExpand all lines: src/node.h

+8-4Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -925,21 +925,25 @@ struct ACHHandle;
925	925	struct NODE_EXTERN DeleteACHHandle { void operator()(ACHHandle*) const; };
926	926	typedef std::unique_ptr<ACHHandle, DeleteACHHandle> AsyncCleanupHookHandle;
927	927
928		- NODE_EXTERN ACHHandle* AddEnvironmentCleanupHookRaw(
	928	+ /* This function is not intended to be used externally, it exists to aid in
	929	+ * keeping ABI compatibility between Node and Electron. */
	930	+ NODE_EXTERN ACHHandle* AddEnvironmentCleanupHookInternal(
929	931	v8::Isolate* isolate,
930	932	void (*fun)(void* arg, void (*cb)(void*), void* cbarg),
931	933	void* arg);
932	934	inline AsyncCleanupHookHandle AddEnvironmentCleanupHook(
933	935	v8::Isolate* isolate,
934	936	void (*fun)(void* arg, void (*cb)(void*), void* cbarg),
935	937	void* arg) {
936		- return AsyncCleanupHookHandle(AddEnvironmentCleanupHookRaw(isolate, fun,
	938	+ return AsyncCleanupHookHandle(AddEnvironmentCleanupHookInternal(isolate, fun,
937	939	arg));
938	940	}
939	941
940		- NODE_EXTERN void RemoveEnvironmentCleanupHookRaw(ACHHandle* holder);
	942	+ /* This function is not intended to be used externally, it exists to aid in
	943	+ * keeping ABI compatibility between Node and Electron. */
	944	+ NODE_EXTERN void RemoveEnvironmentCleanupHookInternal(ACHHandle* holder);
941	945	inline void RemoveEnvironmentCleanupHook(AsyncCleanupHookHandle holder) {
942		- RemoveEnvironmentCleanupHookRaw(holder.get());
	946	+ RemoveEnvironmentCleanupHookInternal(holder.get());
943	947	}
944	948
945	949	/* Returns the id of the current execution context. If the return value is

0 commit comments

Comments

0 (0)