Commit bf7a52b
http: improve for-loop readability in _http_outgoing.js
PR-URL: #26408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 5897bf4 commit bf7a52b
1 file changed
Lines changed: 15 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -295,21 +295,21 @@ function _storeHeader(firstLine, headers) { | |||
| 295 | 295 | header: firstLine | |
| 296 | 296 | }; | |
| 297 | 297 | ||
| 298 | - var key; | ||
| 299 | - if (headers === this[outHeadersKey]) { | ||
| 300 | - for (key in headers) { | ||
| 301 | - const entry = headers[key]; | ||
| 302 | - processHeader(this, state, entry[0], entry[1], false); | ||
| 303 | - } | ||
| 304 | - } else if (Array.isArray(headers)) { | ||
| 305 | - for (var i = 0; i < headers.length; i++) { | ||
| 306 | - const entry = headers[i]; | ||
| 307 | - processHeader(this, state, entry[0], entry[1], true); | ||
| 308 | - } | ||
| 309 | - } else if (headers) { | ||
| 310 | - for (key in headers) { | ||
| 311 | - if (hasOwnProperty(headers, key)) { | ||
| 312 | - processHeader(this, state, key, headers[key], true); | ||
| 298 | + if (headers) { | ||
| 299 | + if (headers === this[outHeadersKey]) { | ||
| 300 | + for (const key in headers) { | ||
| 301 | + const entry = headers[key]; | ||
| 302 | + processHeader(this, state, entry[0], entry[1], false); | ||
| 303 | + } | ||
| 304 | + } else if (Array.isArray(headers)) { | ||
| 305 | + for (const entry of headers) { | ||
| 306 | + processHeader(this, state, entry[0], entry[1], true); | ||
| 307 | + } | ||
| 308 | + } else { | ||
| 309 | + for (const key in headers) { | ||
| 310 | + if (hasOwnProperty(headers, key)) { | ||
| 311 | + processHeader(this, state, key, headers[key], true); | ||
| 312 | + } | ||
| 313 | 313 | } | |
| 314 | 314 | } | |
| 315 | 315 | } | |
0 commit comments