src: prevent changing FunctionTemplateInfo after publish · nodejs/node@bf9a52c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bf9a52c

Browse filesBrowse the repository at this point in the historyBrowse files

codebytere

authored and

targos

committed

src: prevent changing FunctionTemplateInfo after publish

Refs https://chromium-review.googlesource.com/c/v8/v8/+/2718147 Fixes an issue where Node.js tries to call SetClassName on a FunctionTemplate twice in some cases. The above CL made it so that V8 CHECKs when this occurs. It is fixed by ensuring SetClassName is only called once. PR-URL: #46979 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 9962459 commit bf9a52c
Copy full SHA for bf9a52c

2 files changed

+8-3Lines changed: 8 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • histogram.cc
  • node_messaging.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/histogram.cc‎

Copy file name to clipboardExpand all lines: src/histogram.cc

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -345,7 +345,8 @@ void HistogramBase::Initialize(IsolateData* isolate_data,
345	345	SetConstructorFunction(isolate_data->isolate(),
346	346	target,
347	347	"Histogram",
348		- GetConstructorTemplate(isolate_data));
	348	+ GetConstructorTemplate(isolate_data),
	349	+ SetConstructorFunctionFlag::NONE);
349	350	}
350	351
351	352	BaseObjectPtr<BaseObject> HistogramBase::HistogramTransferData::Deserialize(
@@ -371,6 +372,7 @@ Local<FunctionTemplate> IntervalHistogram::GetConstructorTemplate(
371	372	Isolate* isolate = env->isolate();
372	373	tmpl = NewFunctionTemplate(isolate, nullptr);
373	374	tmpl->Inherit(HandleWrap::GetConstructorTemplate(env));
	375	+ tmpl->SetClassName(OneByteString(isolate, "Histogram"));
374	376	tmpl->InstanceTemplate()->SetInternalFieldCount(
375	377	HistogramBase::kInternalFieldCount);
376	378	SetProtoMethodNoSideEffect(isolate, tmpl, "count", GetCount);

Collapse file

‎src/node_messaging.cc‎

Copy file name to clipboardExpand all lines: src/node_messaging.cc

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1496,13 +1496,16 @@ static void InitMessaging(Local<Object> target,
1496	1496	NewFunctionTemplate(isolate, JSTransferable::New);
1497	1497	t->InstanceTemplate()->SetInternalFieldCount(
1498	1498	JSTransferable::kInternalFieldCount);
1499		- SetConstructorFunction(context, target, "JSTransferable", t);
	1499	+ t->SetClassName(OneByteString(isolate, "JSTransferable"));
	1500	+ SetConstructorFunction(
	1501	+ context, target, "JSTransferable", t, SetConstructorFunctionFlag::NONE);
1500	1502	}
1501	1503
1502	1504	SetConstructorFunction(context,
1503	1505	target,
1504	1506	env->message_port_constructor_string(),
1505		- GetMessagePortConstructorTemplate(env));
	1507	+ GetMessagePortConstructorTemplate(env),
	1508	+ SetConstructorFunctionFlag::NONE);
1506	1509
1507	1510	// These are not methods on the MessagePort prototype, because
1508	1511	// the browser equivalents do not provide them.

0 commit comments

Comments

0 (0)