Commit bfc553d
build: fail on CI if leftover processes
If any tests leave processes running after testing results are complete,
fail the test run.
PR-URL: #11269
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>1 parent f0eee61 commit bfc553d
1 file changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -199,12 +199,22 @@ test-ci-js: | |||
| 199 | 199 | $(PYTHON) tools/test.py -p tap --logfile test.tap \ | |
| 200 | 200 | --mode=release --flaky-tests=$(FLAKY_TESTS) \ | |
| 201 | 201 | $(TEST_CI_ARGS) $(CI_JS_SUITES) | |
| 202 | + # Clean up any leftover processes | ||
| 203 | + PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ | ||
| 204 | + if [ "$${PS_OUT}" ]; then \ | ||
| 205 | + echo $${PS_OUT} | $(XARGS) kill; exit 1; \ | ||
| 206 | + fi | ||
| 202 | 207 | ||
| 203 | 208 | test-ci: LOGLEVEL := info | |
| 204 | 209 | test-ci: | build-addons | |
| 205 | 210 | out/Release/cctest --gtest_output=tap:cctest.tap | |
| 206 | 211 | $(PYTHON) tools/test.py -p tap --logfile test.tap --mode=release --flaky-tests=$(FLAKY_TESTS) \ | |
| 207 | 212 | $(TEST_CI_ARGS) $(CI_NATIVE_SUITES) $(CI_JS_SUITES) | |
| 213 | + # Clean up any leftover processes | ||
| 214 | + PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \ | ||
| 215 | + if [ "$${PS_OUT}" ]; then \ | ||
| 216 | + echo $${PS_OUT} | $(XARGS) kill; exit 1; \ | ||
| 217 | + fi | ||
| 208 | 218 | ||
| 209 | 219 | test-release: test-build | |
| 210 | 220 | $(PYTHON) tools/test.py --mode=release | |
0 commit comments