test: skip in test-buffer-tostring-rangeerror on allocation failure · nodejs/node@bffd4ec · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit bffd4ec

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

marco-ippolito

committed

test: skip in test-buffer-tostring-rangeerror on allocation failure

If the buffer allocation fails due to insufficient memory, there is no point continue testing toString(). PR-URL: #58415 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 7c449ed commit bffd4ec
Copy full SHA for bffd4ec

1 file changed

+19-5Lines changed: 19 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-buffer-tostring-rangeerror.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-buffer-tostring-rangeerror.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-buffer-tostring-rangeerror.js

+19-5Lines changed: 19 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -18,8 +18,22 @@ const message = {
18	18	code: 'ERR_STRING_TOO_LONG',
19	19	name: 'Error',
20	20	};
21		- assert.throws(() => Buffer(len).toString('utf8'), message);
22		- assert.throws(() => SlowBuffer(len).toString('utf8'), message);
23		- assert.throws(() => Buffer.alloc(len).toString('utf8'), message);
24		- assert.throws(() => Buffer.allocUnsafe(len).toString('utf8'), message);
25		- assert.throws(() => Buffer.allocUnsafeSlow(len).toString('utf8'), message);
	21	+
	22	+ function test(getBuffer) {
	23	+ let buf;
	24	+ try {
	25	+ buf = getBuffer();
	26	+ } catch (e) {
	27	+ // If the buffer allocation fails, we skip the test.
	28	+ if (e.code === 'ERR_MEMORY_ALLOCATION_FAILED' || /Array buffer allocation failed/.test(e.message)) {
	29	+ return;
	30	+ }
	31	+ }
	32	+ assert.throws(() => { buf.toString('utf8'); }, message);
	33	+ }
	34	+
	35	+ test(() => Buffer(len));
	36	+ test(() => SlowBuffer(len));
	37	+ test(() => Buffer.alloc(len));
	38	+ test(() => Buffer.allocUnsafe(len));
	39	+ test(() => Buffer.allocUnsafeSlow(len));

0 commit comments

Comments

0 (0)