lib: replace spread operator with primordials function · nodejs/node@c004aba · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 753
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit c004aba

Browse filesBrowse the repository at this point in the historyBrowse files

MCprotein

authored and

targos

committed

lib: replace spread operator with primordials function

replaced the spread operator with ArrayPrototypeSlice to avoid reliance on user-mutable methods and enhance the safety of array iteration Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration PR-URL: #54053 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

1 parent d3a743f commit c004aba
Copy full SHA for c004aba

1 file changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/streams
  • compose.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/streams/compose.js‎

Copy file name to clipboardExpand all lines: lib/internal/streams/compose.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,5 +1,9 @@
1	1	'use strict';
2	2
	3	+ const {
	4	+ ArrayPrototypeSlice,
	5	+ } = primordials;
	6	+
3	7	const { pipeline } = require('internal/streams/pipeline');
4	8	const Duplex = require('internal/streams/duplex');
5	9	const { destroyer } = require('internal/streams/destroy');
@@ -30,7 +34,7 @@ module.exports = function compose(...streams) {
30	34	return Duplex.from(streams[0]);
31	35	}
32	36
33		- const orgStreams = [...streams];
	37	+ const orgStreams = ArrayPrototypeSlice(streams);
34	38
35	39	if (typeof streams[0] === 'function') {
36	40	streams[0] = Duplex.from(streams[0]);

0 commit comments

Comments

0 (0)