Commit c052967
bootstrap: provide usable error on missing internal module
Due to how bootstrap/loaders.js itself is loaded and invoked,
stacktraces from it are munged and no longer point back to the error
source.
That resulted in the following unhelpful error if an internal module
was missing or misnamed:
```
internal/bootstrap/loaders.js:190
return mod.compile();
^
TypeError: Cannot read property 'compile' of undefined
```
This changes that to at least print the id that was attempted to be
loaded:
```
internal/bootstrap/loaders.js:189
if (!mod) throw new TypeError(`Missing internal module '${id}'`);
^
TypeError: Missing internal module 'internal/a'
```
PR-URL: #29593
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 4954792 commit c052967
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -186,6 +186,9 @@ function nativeModuleRequire(id) { | |||
| 186 | 186 | } | |
| 187 | 187 | ||
| 188 | 188 | const mod = NativeModule.map.get(id); | |
| 189 | + // Can't load the internal errors module from here, have to use a raw error. | ||
| 190 | + // eslint-disable-next-line no-restricted-syntax | ||
| 191 | + if (!mod) throw new TypeError(`Missing internal module '${id}'`); | ||
| 189 | 192 | return mod.compile(); | |
| 190 | 193 | } | |
| 191 | 194 | ||
0 commit comments