Commit c0875d1
src: avoid casting std::trunc(... / ...) to size_t
Given that the divisor is not zero, the result of dividing unsigned
integers is an unsigned integer that is always rounded down, i.e.,
there is no need to call std::trunc(). Doing so unnecessarily yields
a floating-point number, requiring the result to be cast to an unsigned
integer again.
PR-URL: #44467
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 8f3ed25 commit c0875d1
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -65,8 +65,7 @@ Maybe<bool> SecretKeyGenTraits::AdditionalConfig( | |||
| 65 | 65 | SecretKeyGenConfig* params) { | |
| 66 | 66 | Environment* env = Environment::GetCurrent(args); | |
| 67 | 67 | CHECK(args[*offset]->IsUint32()); | |
| 68 | - params->length = static_cast<size_t>( | ||
| 69 | - std::trunc(args[*offset].As<Uint32>()->Value() / CHAR_BIT)); | ||
| 68 | + params->length = args[*offset].As<Uint32>()->Value() / CHAR_BIT; | ||
| 70 | 69 | if (params->length > INT_MAX) { | |
| 71 | 70 | THROW_ERR_OUT_OF_RANGE(env, | |
| 72 | 71 | "length must be less than or equal to %u bits", | |
0 commit comments