Commit c0d236f
build: make build-addons errors fail the build
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and
then uses `touch` to update a timestamp file. Unconditionally calling
`touch` was losing the exit code from `tools/doc/addon-verify.js` so
any errors produced by that script were not failing the build.
PR-URL: #38983
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent f7724ab commit c0d236f
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -352,7 +352,7 @@ test/addons/.docbuildstamp: $(DOCBUILDSTAMP_PREREQS) tools/doc/node_modules | |||
| 352 | 352 | else \ | |
| 353 | 353 | $(RM) -r test/addons/??_*/; \ | |
| 354 | 354 | [ -x $(NODE) ] && $(NODE) $< || node $< ; \ | |
| 355 | - touch $@; \ | ||
| 355 | + [ $$? -eq 0 ] && touch $@; \ | ||
| 356 | 356 | fi | |
| 357 | 357 | ||
| 358 | 358 | ADDONS_BINDING_GYPS := \ | |
0 commit comments