Commit c10b131
test: make sure tmpdir is created before using it
Otherwise it throws ENOENT when the folder happens to be cleaned
PR-URL: #25224
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 1ccaf9a commit c10b131
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,6 +15,8 @@ const tmpdir = require('../common/tmpdir'); | |||
| 15 | 15 | const command = common.isWindows ? 'cd' : 'pwd'; | |
| 16 | 16 | const options = { cwd: tmpdir.path }; | |
| 17 | 17 | ||
| 18 | + tmpdir.refresh(); | ||
| 19 | + | ||
| 18 | 20 | if (common.isWindows) { | |
| 19 | 21 | // This test is not the case for Windows based systems | |
| 20 | 22 | // unless the `shell` options equals to `true` | |
@@ -31,12 +33,13 @@ const testCases = [ | |||
| 31 | 33 | const expectedResult = tmpdir.path.trim().toLowerCase(); | |
| 32 | 34 | ||
| 33 | 35 | const results = testCases.map((testCase) => { | |
| 34 | - const { stdout, stderr } = spawnSync( | ||
| 36 | + const { stdout, stderr, error } = spawnSync( | ||
| 35 | 37 | command, | |
| 36 | 38 | testCase, | |
| 37 | 39 | options | |
| 38 | 40 | ); | |
| 39 | 41 | ||
| 42 | + assert.ifError(error); | ||
| 40 | 43 | assert.deepStrictEqual(stderr, Buffer.alloc(0)); | |
| 41 | 44 | ||
| 42 | 45 | return stdout.toString().trim().toLowerCase(); | |
0 commit comments