Commit c136d59
test: use spawnSync() full name
test-cli-bad-options.js uses `spawnSync()` but renames it as `spawn()`
which caused me a bit of confusion for a bit until I realized what was
going on. Rename the variable `spawnSync()` for
readability/maintainability.
PR-URL: #41327
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 5fc886f commit c136d59
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,7 +4,7 @@ require('../common'); | |||
| 4 | 4 | // Tests that node exits consistently on bad option syntax. | |
| 5 | 5 | ||
| 6 | 6 | const assert = require('assert'); | |
| 7 | - const spawn = require('child_process').spawnSync; | ||
| 7 | + const { spawnSync } = require('child_process'); | ||
| 8 | 8 | ||
| 9 | 9 | if (process.features.inspector) { | |
| 10 | 10 | requiresArgument('--inspect-port'); | |
@@ -15,7 +15,7 @@ if (process.features.inspector) { | |||
| 15 | 15 | requiresArgument('--eval'); | |
| 16 | 16 | ||
| 17 | 17 | function requiresArgument(option) { | |
| 18 | - const r = spawn(process.execPath, [option], { encoding: 'utf8' }); | ||
| 18 | + const r = spawnSync(process.execPath, [option], { encoding: 'utf8' }); | ||
| 19 | 19 | ||
| 20 | 20 | assert.strictEqual(r.status, 9); | |
| 21 | 21 | ||
0 commit comments